fix: prevent agate type-conflict during catalog merge (#1392)#1428
Open
fix: prevent agate type-conflict during catalog merge (#1392)#1428
Conversation
…ge conflict (#1392) Without this, agate's value-driven type inference can mark a metadata column as Number in one schema and Text in another, causing catch_as_completed's merge to raise on the conflict during dbt docs generate.
Coverage report
Click to see where and how coverage changed
This report was generated by python-coverage-comment-action |
||||||||||||||||||||||||
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1428 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1428 — UC cluster ✅ success · SQL warehouse ❌ failure · All-purpose cluster ✅ success |
Collaborator
Author
|
The failure is caused by a flaky test where the warehouse is under stress and could not return a response in the expected time period. I re-ran the test locally to be 100% sure + this is in a totally unrelated code path. Did not want to trigger a full rerun and waste resources.Tests are also run nightly on main so risk is minimal/nil. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dbt docs generatefailing withRuntimeError: Tables contain columns with the same names ... but different typesduring catalog merge._get_schema_for_catalog, mirroring_catalog_filter_tablein dbt-adapters base (which dbt-databricks bypasses).Test plan